fix(node): golangci-lint failures + broken test Dockerfile/script#984
Merged
Conversation
Lint (node module): - errcheck: handle ignored error returns in block_fsm (rc.Close, sink.Cancel), ha_service (transport/stableStore/logStore Close) and enclave_signer (conn.SetDeadline) - gosec G112: set ReadHeaderTimeout on the hakeeper RPC server and the node metrics HTTP server - gosec G301: tighten raft StorageDir permissions from 0o755 to 0o750 - gofmt: reformat ha_service.go, signer.go, verifier.go - misspell: initialised->initialized, initialises->initializes, cancelled->canceled Build/test harness: - drop the dead `COPY ./morph/oracle/go.mod` step from the l2-node and tx-submitter test Dockerfiles (the oracle project no longer exists, so the COPY fails the build) - run-test.sh: fix a non-existent compose service name (sentry-geth-0 -> sentry-el-0) that aborted L2 startup Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
curryxbo
approved these changes
Jun 10, 2026
The APIBackend methods take context.Context only to satisfy the go-ethereum JSON-RPC handler signature; the underlying hashicorp/raft membership and leadership ops are synchronous and not context-cancellable, and already carry their own raftTimeout. Document this so reviewers don't flag the unused ctx as a bug. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small, behavior-preserving fixes for
feat/sequencer-finalso CI lint passes and the docker-sequencer-test harness builds/starts again. No logic changes.Lint (golangci-lint, node module)
block_fsm.go(rc.Close,sink.Cancel),ha_service.go(transport/stableStore/logStoreClose),enclave_signer.go(conn.SetDeadline×2)ReadHeaderTimeouton the hakeeper RPC server and the node metrics HTTP serverStorageDirpermissions0o755→0o750ha_service.go,signer.go,verifier.goinitialised→initialized,initialises→initializes,cancelled→canceledBuild / test harness
COPY ./morph/oracle/go.modstep from the l2-node and tx-submitter test Dockerfiles — theoracleproject no longer exists on this branch, so the COPY fails the image build.run-test.sh: fix a non-existent compose service name (sentry-geth-0→sentry-el-0) that aborted L2 startup underset -e.Test plan
go run ../build/lint.gofromnode/→ exit 0 (was 18 errors)run-test.sh build→ both test images build cleanly (oracle COPY removed)run-test.sh setup+start→ 4-node L2 + sentry come up; PBFT→V2 upgrade at height 10; cluster produces blocks and stays hash-consistent