Add <fmt/format.h> for fmt 11+ compatibility - #756
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
=======================================
Coverage 52.93% 52.93%
=======================================
Files 138 138
Lines 10651 10651
Branches 1129 1129
=======================================
Hits 5637 5637
Misses 5006 5006
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
idesign0
force-pushed
the
macos-fmt-pr
branch
2 times, most recently
from
August 14, 2026 10:00
770fe85 to
6fc5b05
Compare
Contributor
Author
|
fyi, @traversaro. |
Signed-off-by: idesign0 <dhruvpatel2991998@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fmt 11 (2024) reorganized its headers:
fmt::formatand the other formatting functions moved out of<fmt/core.h>into<fmt/format.h>(core.hbecame a lightweight base). Files that include only<fmt/core.h>and callfmt::format(...)fail to compile against fmt 11 / 12 with:Homebrew now ships fmt 12.2.0, so this surfaces on macOS / Apple-clang builds.
Fix
Add
#include <fmt/format.h>to the affected file(s):<fmt/format.h>providesfmt::formatin every fmt release (it pulls in the base header), so this is backward-compatible — no minimum-fmt bump and no behaviour change on older fmt.Tested on
macos-26runnersclang-2100.1.1.101, targetarm64-apple-darwin25.5.0), C++17, libc++🤖 Generated with Claude Code