RELOPS-2487: retire the nucwimfxci stack; point the downloader SP at hardwareimaging - #326
Merged
Merged
Conversation
jwmossmoz
previously approved these changes
Aug 26, 2026
markcor
enabled auto-merge (squash)
August 26, 2026 15:55
…hardwareimaging Phase 2 of the nuc-wim -> hardware-imaging migration, completing the phase-1 create-alongside (#317). Removes nuc-wim-storage.tf entirely: the old 'nucwimfxci' account, its base/ and captured/ containers, the nuc-wim RG/VNet/subnet, the wim_builder identity and the nine wim_* role assignments. Every blob the old account held has a verified counterpart under hardwareimaging resources/ and captured/, and worker-images has provisioned exclusively into rg-central-us-hardware-imaging since the cutover - no code in win-hw-wim/ or ci/ references the old RG, VNet, subnet or identity. Adds azurerm_role_assignment.mdc1_hwimg_ro: Storage Blob Data Reader for the MDC1 downloader SP, scoped to the new account's 'captured' container. That grant existed only on nucwimfxci, so since the cutover the SP has had no access to the account the images actually live in. This is the "point the SP at the right ones" fix. The aliased AAD provider (azurerm.nuc_wim_aad) and the relops_group_object_id / nuc_wim_downloader_object_id variables lived in the deleted file and are moved into hardware-imaging-storage.tf unchanged. Deliberately NOT doing the cosmetic resource renames the phase-1 header proposed (state mv captured_hwimg -> captured, dropping _hwimg suffixes): hand-run state surgery adds risk to a change that already destroys a storage account. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
markcor
force-pushed
the
hardware-imaging-retire-nucwimfxci
branch
from
August 26, 2026 17:50
19cedb5 to
108707d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grants the MDC1 downloader SP the access it needs on the
hardwareimagingaccount.What this adds
azurerm_role_assignment.mdc1_hwimg_ro— Storage Blob Data Reader for the MDC1 downloader SP (ae54832f-8931-46d8-8faa-133637e72798), scoped to thecapturedcontainer so the SP can read build outputs and nothing else. Guarded bycountonvar.nuc_wim_downloader_object_id; leaving that empty skips the grant and falls back to the SAS path.hardware-imaging-storage.tfnow owns the aliased AAD providerazurerm.nuc_wim_aadand therelops_group_object_id/nuc_wim_downloader_object_idvariables. The declarations themselves are unchanged — same defaults, same descriptions.Notes
hardwareimaging/capturedand verified withaz role assignment list.terraform planhere still reports one in-place change to thenetwork_rulesblock onazurerm_storage_account.hardware-imaging. That is a pre-existing perpetual diff — Azure does not persist an all-defaults block, so the provider re-proposes it every run. It predates this branch and is unrelated to this change.🤖 Generated with Claude Code