drop ReviewActionReasons support in reviewer tools, and cinder_policy_review_reasons switch#24825
Open
eviljeff wants to merge 1 commit intomozilla:masterfrom
Open
drop ReviewActionReasons support in reviewer tools, and cinder_policy_review_reasons switch#24825eviljeff wants to merge 1 commit intomozilla:masterfrom
eviljeff wants to merge 1 commit intomozilla:masterfrom
Conversation
0c85821 to
107fdec
Compare
eviljeff
commented
May 1, 2026
| ) | ||
| DECISION_ACTIONS.AMO_DISABLE_ADDON, | ||
| DECISION_ACTIONS.AMO_REJECT_VERSION_ADDON, | ||
| DECISION_ACTIONS.AMO_REJECT_VERSION_WARNING_ADDON, |
Member
Author
There was a problem hiding this comment.
This is a drive-by fix - Andreas mentioned on Slack that policies with this enforcement action weren't showing up.
107fdec to
dcf6a1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#16121
Description
Removes support for ReviewActionReason in the reviewer tools, and the
cinder_policy_review_reasonswaffle switch.Context
There's a lot of old code removed, but also a fair number of reviewer tests were only testing with reasons so needed updating.
Apparently auto_reject only took into account reviewer action reasons too...
I retained support in admin and models for historic reference, and that it's still used in the blocklist admin - follow-up would be to strip out functionality that is unused for blocklist admin - or just remove it entirely as manual blocklist submissions will become more and more rare going forward.
The reviewer tools reply action was using reviewactionreaons (for the canned responses), irregardless of the waffle switch, but switching it to use Cinder Policies didn't make much sense - reply is used when we're not enforcing a policy. So I just removed support.
Testing
Approve/Reject some add-ons in the reviewer tools and check everything works as expected.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.