Skip to content

drop ReviewActionReasons support in reviewer tools, and cinder_policy_review_reasons switch#24825

Open
eviljeff wants to merge 1 commit intomozilla:masterfrom
eviljeff:16121-rm-review-action-reasons
Open

drop ReviewActionReasons support in reviewer tools, and cinder_policy_review_reasons switch#24825
eviljeff wants to merge 1 commit intomozilla:masterfrom
eviljeff:16121-rm-review-action-reasons

Conversation

@eviljeff
Copy link
Copy Markdown
Member

@eviljeff eviljeff commented May 1, 2026

Fixes: mozilla/addons#16121

Description

Removes support for ReviewActionReason in the reviewer tools, and the cinder_policy_review_reasons waffle switch.

Context

There's a lot of old code removed, but also a fair number of reviewer tests were only testing with reasons so needed updating.

Apparently auto_reject only took into account reviewer action reasons too...

I retained support in admin and models for historic reference, and that it's still used in the blocklist admin - follow-up would be to strip out functionality that is unused for blocklist admin - or just remove it entirely as manual blocklist submissions will become more and more rare going forward.

The reviewer tools reply action was using reviewactionreaons (for the canned responses), irregardless of the waffle switch, but switching it to use Cinder Policies didn't make much sense - reply is used when we're not enforcing a policy. So I just removed support.

Testing

Approve/Reject some add-ons in the reviewer tools and check everything works as expected.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff force-pushed the 16121-rm-review-action-reasons branch from 0c85821 to 107fdec Compare May 1, 2026 14:35
)
DECISION_ACTIONS.AMO_DISABLE_ADDON,
DECISION_ACTIONS.AMO_REJECT_VERSION_ADDON,
DECISION_ACTIONS.AMO_REJECT_VERSION_WARNING_ADDON,
Copy link
Copy Markdown
Member Author

@eviljeff eviljeff May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a drive-by fix - Andreas mentioned on Slack that policies with this enforcement action weren't showing up.

@eviljeff eviljeff force-pushed the 16121-rm-review-action-reasons branch from 107fdec to dcf6a1d Compare May 1, 2026 15:27
@eviljeff eviljeff marked this pull request as ready for review May 5, 2026 09:33
@eviljeff eviljeff requested a review from diox May 5, 2026 09:34
@eviljeff eviljeff changed the title no more reasons drop ReviewActionReasons support in reviewer tools, and cinder_policy_review_reasons switch May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Remove old ReviewActionReasons code and cinder_policy_review_reasons_enabled waffle switch

1 participant