Overwrite CARGO_BUILD_BUILD_DIR as well to avoid deadlocks - #1174
Merged
Conversation
This follows how CARGO_TARGET_DIR is handled and sets the same directory.
emilio
reviewed
Jul 22, 2026
emilio
approved these changes
Jul 22, 2026
Collaborator
|
I think this is fine, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I was playing around with
CARGO_BUILD_BUILD_DIR(https://releases.rs/docs/1.91.0/#cargo) the last couple of days and noticed that my Rust workspace, which uses cbindgens[pase.expand]feature, would deadlock when building.Since cbindgen is already handling this issue related to
CARGO_TARGET_DIRI wanted to open this PR to apply the same treatment toCARGO_BUILD_BUILD_DIR. I think that it is probably ok to not introduce a newCARGO_EXPAND_BUILD_DIRenv var because I feel like it would be ok for the expand-related artifacts to be located in the same place.I hope that it is ok that I've opened this PR. I am open to discuss any changes or additions that are suggested. :)