refactor: bump syn to v3 - #1175
Merged
Merged
Conversation
AudaciousAxiom
commented
Jul 26, 2026
| if receiver.colon_token.is_some() { | ||
| self_ty = Type::load(receiver.ty.as_ref())?.unwrap_or(self_ty); | ||
| } | ||
| match &receiver.kind { |
Contributor
Author
There was a problem hiding this comment.
This is the part that requires the most attention due to the change around receivers and pointers.
AudaciousAxiom
marked this pull request as ready for review
July 26, 2026 08:20
emilio
requested changes
Jul 26, 2026
AudaciousAxiom
force-pushed
the
refactor/syn-v3
branch
from
July 26, 2026 13:02
772dcdb to
141bf3b
Compare
emilio
approved these changes
Jul 26, 2026
emilio
enabled auto-merge
July 26, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the recent release of
synv3, this bumps the dependency and makes the necessary refactors, with the goal of reducing dependency duplication in the dependents. The MSRV ofsynv3 is now 1.71 but that shouldn't be a problem withcbindgen's MSRV of 1.74.I've been trough the changelog and didn't find any other relevant breaking changes (but there is quite a few of them so I could have missed some). The biggest change is how receivers and the constness of pointers is now encoded: compare
Receiver@v3withReceiver@v2andTypePtr@v3withTypePtr@v2.I've run
cargo testbut didn't do any other kind of testing.