feat(schemas): Add Firefox Labs fields to SDK experiment schemas#15883
Open
freshstrangemusic wants to merge 1 commit into
Open
feat(schemas): Add Firefox Labs fields to SDK experiment schemas#15883freshstrangemusic wants to merge 1 commit into
freshstrangemusic wants to merge 1 commit into
Conversation
freshstrangemusic
requested review from
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
freshstrangemusic
changed the base branch from
freshstrangemusic/push-kykuptuyzokl
to
main
freshstrangemusic
force-pushed
the
freshstrangemusic/push-rqpvpzkkqksx
branch
3 times, most recently
from
c99dfde to
b64feb3
Compare
This commit is a breaking change. Because: - we are bringing Firefox Labs to the SDK; and - our Pydantic models cannot distinguish between the firefoxLabsDescriptionLinks field being absent or null This commit: - adds most Firefox Labs fields (no firefoxLabsGroup) to the SDK experiment schemas; and - removes the hard requirement for the presence of the firefoxLabsDescriptionLinks field in order to align the validation behaviour between the Pydantic model and the generated JSON schema. Fixes #15865
freshstrangemusic
force-pushed
the
freshstrangemusic/push-rqpvpzkkqksx
branch
from
b64feb3 to
de0e04b
Compare
mikewilli
approved these changes
Jun 10, 2026
mikewilli
left a comment
mikewilli
left a comment
Contributor
There was a problem hiding this comment.
I can't speak to the context or specifics here, but the changes look appropriate and correct to me.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a breaking change.
Because:
firefoxLabsDescriptionLinks field being absent or null
This commit:
experiment schemas; and
firefoxLabsDescriptionLinks field in order to align the validation
behaviour between the Pydantic model and the generated JSON schema.
Fixes #15865