feat(nimbus): Celery tasks to run holdback analysis weekly#16136
Merged
Conversation
yashikakhurana
requested review from
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
yashikakhurana
changed the title
Contributor
Author
|
Blocked on this #16096 |
mikewilli
previously requested changes
Jun 30, 2026
added 6 commits
June 30, 2026 15:50
…riod and trigger Jetstream rerun
…x test expectations Holdback experiments never pause enrollment so actual_enrollment_end_date is always None, causing the task to skip every experiment. Switch to computed_enrollment_end_date (start_date + proposed_enrollment) which correctly reflects when the initial enrollment window expires. Update test comment and expected value to match the corrected calculation (36 days since end → weeks_elapsed=5 → 14+35=49).
…sized context managers
…back - Run daily instead of weekly (holdbacks can launch any day) - Use today - 21 days as rolling enrollment_end (observation period) - Skip experiments with end_date set (actually ended holdbacks) - Update _enrollment_end_date instead of proposed_enrollment - Add changelog entry per updated experiment - Compute proposedEnrollment, enrollmentEndDate, endDate on-the-fly in v8 serializer for active holdbacks — real fields stay untouched - Add HOLDBACK_ENROLLMENT_UPDATED changelog message constant
…on _enrollment_end_date
… serializer methods
mikewilli
previously requested changes
Jul 7, 2026
mikewilli
left a comment
mikewilli
left a comment
Contributor
There was a problem hiding this comment.
I suggested a couple small changes, but more importantly I think there's still some confusion over which dates to fake, when to fake them, and what they should be set to. My understanding of what we want to do here isn't quite in line with what you have here, and I'm not totally sure if that's a misunderstanding on my part or if I'm just not quite explaining it clearly enough.
Let me know if you want to chat about it to try and make sure we're on the same page.
- Move HOLDBACK_OBSERVATION_DAYS constant to settings.py - Remove _enrollment_end_date update from task — serializer computes on-the-fly - Serializer computes fake enrollment end (today - 21 days) when holdback has no explicit enrollment_end_date, rather than relying on stored value - Use shared constant from settings in both task and serializer
Contributor
Author
|
@mikewilli did the changes, I think its clear now, not updating the dates to not impact any working functionality, computing on the fly |
added 6 commits
July 8, 2026 09:11
…nt + 21 observation)
…p if enrollment stopped
mikewilli
approved these changes
Jul 8, 2026
mikewilli
left a comment
mikewilli
left a comment
Contributor
There was a problem hiding this comment.
Alright this is looking good now! Please change the schedule before merging, the other comments are up to you.
Thanks for working through everything.
| update_fields = {"do_rerun_timestamp": now} | ||
| if not experiment.do_rerun: | ||
| update_fields["do_rerun"] = True | ||
| NimbusExperiment.objects.filter(pk=experiment.pk).update(**update_fields) |
Contributor
There was a problem hiding this comment.
I don't know if it makes a difference, but should this be .get instead of .filter?
Contributor
Author
There was a problem hiding this comment.
I think we don't need this anymore as we are not updating any private property, we can directly access for the save
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #16086