Conversation
nshirley
commented
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
test/remote/check_reputation_tests.jsintermittently failed in the nightlyIntegration Test. The flaky subtest (
query reputation stub directly using ip-reputation-js-client) assertedtimingPhases.total > 0, but the clientcomputes that total from integer-millisecond
Date.now()deltas, so asub-millisecond localhost round-trip produced a
0mstotal and failed theassertion.
fxa-customs-serveris no longer in active use, so the subtest isn't worthstabilizing.
This pull request
repJSClientsetup from
check_reputation_tests.js. No source or other tests are touched.Issue that this pull request solves
Closes: FXA-13959
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
ipReputationClient.jssource and the rest of the customs-server remainuntouched for a future cleanup, since the service is no longer in active use.