Skip to content

fix(customs): stabilize flaky check_reputation integration test#20742

Draft
nshirley wants to merge 1 commit into
mainfrom
fxa-13959
Draft

fix(customs): stabilize flaky check_reputation integration test#20742
nshirley wants to merge 1 commit into
mainfrom
fxa-13959

Conversation

@nshirley

@nshirley nshirley commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Because

  • test/remote/check_reputation_tests.js intermittently failed in the nightly
    Integration Test. The flaky subtest (query reputation stub directly using ip-reputation-js-client) asserted timingPhases.total > 0, but the client
    computes that total from integer-millisecond Date.now() deltas, so a
    sub-millisecond localhost round-trip produced a 0ms total and failed the
    assertion.
  • fxa-customs-server is no longer in active use, so the subtest isn't worth
    stabilizing.

This pull request

  • Removes the flaky direct-client subtest and its now-unused repJSClient
    setup from check_reputation_tests.js. No source or other tests are touched.

Issue that this pull request solves

Closes: FXA-13959

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

  • Scoped deliberately small: only the flaky subtest is removed. The
    ipReputationClient.js source and the rest of the customs-server remain
    untouched for a future cleanup, since the service is no longer in active use.

Comment thread packages/fxa-customs-server/test/local/ipReputationClient_tests.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant