Skip to content

rustc option "instrument-coverage" stabilized#790

Merged
marco-c merged 9 commits into
mozilla:masterfrom
kazuk:master
Apr 13, 2022
Merged

rustc option "instrument-coverage" stabilized#790
marco-c merged 9 commits into
mozilla:masterfrom
kazuk:master

Conversation

@kazuk

@kazuk kazuk commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

then change -Z to -C

see: rust-lang/rust#90132

@marco-c

marco-c commented Mar 15, 2022

Copy link
Copy Markdown
Collaborator

@kazuk it is not stable yet in the latest Rust version. We need to wait on 1.59.

@marco-c

marco-c commented Mar 15, 2022

Copy link
Copy Markdown
Collaborator

Once 1.59 is out, we can also remove mentions to RUSTC_BOOTSTRAP.

@kazuk

kazuk commented Mar 15, 2022

Copy link
Copy Markdown
Contributor Author

My understanding, grcov requires "Nightly" Rust.
So I think no need to wait "Stable" Rust 1.59.

@marco-c

marco-c commented Mar 15, 2022

Copy link
Copy Markdown
Collaborator

It is possible to use stable rust (by setting the RUSTC_BOOTSTRAP environment variable).

@marco-c

marco-c commented Apr 7, 2022

Copy link
Copy Markdown
Collaborator

@kazuk Rust 1.60 is out with support for source-based coverage instrumentation. I think we can now merge this, but first we have to remove mentions to RUSTC_BOOTSTRAP. Could you update the PR?

@kazuk

kazuk commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

I update Usage line, and update "grcov with Travis" example.

Comment thread README.md Outdated
Comment thread README.md Outdated

@marco-c marco-c left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c marco-c merged commit db909c4 into mozilla:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants