feat: add --use-cloud-function flag to validate_config#3286
Open
scholtzan wants to merge 1 commit into
Open
Conversation
Add a --use-cloud-function/--no-use-cloud-function option to validate_config (default on). With --no-use-cloud-function, queries are dry run using the current user's credentials instead of the dry run Cloud Function's service account, allowing validation of configs that reference tables only the user can read (e.g. personal analysis tables).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
--use-cloud-function/--no-use-cloud-functionoption tovalidate_config(default is stilltrue). With--no-use-cloud-function, queries are dry run using the current user's credentials instead of the dry run Cloud Function's service account, allowing validation of configs that reference tables only the user can read (e.g. personal analysis tables).This came up in https://mozilla.slack.com/archives/C4D5ZA91B/p1783631377972719
If I remember correctly, it was intentional for the dryrun SA not to have access to personal/tmp tables. Though I don't remember the full reason. This flag would be useful in any case though, e.g. if tables are in sandbox projects.