feat: all backends support making them as read-only#2705
Open
AJIOB wants to merge 1 commit into
Open
Conversation
28a49ca to
1e6bacb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
==========================================
+ Coverage 74.51% 74.56% +0.04%
==========================================
Files 70 70
Lines 39652 39793 +141
==========================================
+ Hits 29546 29670 +124
- Misses 10106 10123 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
56b0296 to
aab1fa8
Compare
17b64d7 to
b849dc1
Compare
Contributor
Author
|
Hi @sylvestre . Is it ok to you? |
sylvestre
reviewed
Jun 4, 2026
sylvestre
reviewed
Jun 4, 2026
Collaborator
|
please add more tests:
|
Contributor
Author
|
Thanks, will fix the PR. Looks like the read-only short-circuit was tested via |
9646b21 to
884ca5d
Compare
884ca5d to
5e18212
Compare
Contributor
Author
|
I've added 2 tests in that PR:
|
Contributor
Author
|
@sylvestre , I've fixed all you suggested, thanks. Is it OK now? |
Contributor
Author
|
Hi @sylvestre, Graceful ping about the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the local developers we want to provide the access to the remote cache server in read-only mode.
So, this PR allows read-only access to read-write storages via per-storage specific flag