Prefer core::marker and core::mem to fix --no-default-features -F gecko-ffi#82
Merged
Merged
Conversation
Collaborator
|
@kpcyrd Can you run |
Contributor
Author
|
Done :) I can apply the patch downstream, if you don't mind releasing a new version it would save some time for the next person not needing to un-apply the patch again. |
Collaborator
|
Published as v0.2.17 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried updating the Debian package to 0.2.16 and since our tests build a large number of different feature combinations, I noticed some code fails to compile when the
stdfeature is not enabled.The code doesn't actually need std:: so I changed the import to core::
(thanks @bertptrs for the help checking if this would be a breaking change in the public api)