fix(logviewer): line offset for error lines#9549
Open
camd wants to merge 1 commit into
Open
Conversation
… highlight offset
The viewer split the raw log with text.split('\n'), but the backend records
error line_numbers via requests.iter_lines() (Python's bytes.splitlines()),
which also breaks on bare CR (\r) and CRLF. Bare carriage returns (common in
test progress output) are counted as line breaks by the parser but not by
split('\n'), so every line after a \r drifts and the red error highlight lands
a few lines off from the actual failure line.
Add a splitLogIntoLines() helper that splits on /\r\n|\r|\n/ to match the
parser exactly, keeping displayed line numbers aligned with the recorded
error line_numbers. Handling \r\n as one break also drops the stray trailing
\r that CRLF logs left on every line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9549 +/- ##
========================================
Coverage 82.94% 82.94%
========================================
Files 613 613
Lines 35372 35374 +2
Branches 3208 3269 +61
========================================
+ Hits 29338 29340 +2
+ Misses 5880 5665 -215
- Partials 154 369 +215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2041837
The viewer split the raw log with text.split('\n'), but the backend records error line_numbers via requests.iter_lines() (Python's bytes.splitlines()), which also breaks on bare CR (\r) and CRLF. Bare carriage returns (common in test progress output) are counted as line breaks by the parser but not by split('\n'), so every line after a \r drifts and the red error highlight lands a few lines off from the actual failure line.
Add a splitLogIntoLines() helper that splits on /\r\n|\r|\n/ to match the parser exactly, keeping displayed line numbers aligned with the recorded error line_numbers. Handling \r\n as one break also drops the stray trailing \r that CRLF logs left on every line.