Upgrade urllib3 to 2.6.3#9556
Merged
Merged
Conversation
urllib3 2.x changes how gzip content-encoding is decompressed during streaming, which shifts line boundaries in the log parser's output. The parsed content is identical — only the line-number offsets differ. Regenerated all 16 .logview.json test fixtures to match urllib3 2.x decompression behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9556 +/- ##
========================================
Coverage 82.94% 82.94%
========================================
Files 613 613
Lines 35372 35372
Branches 3263 3269 +6
========================================
Hits 29338 29338
- Misses 5665 5880 +215
+ Partials 369 154 -215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Archaeopteryx
approved these changes
May 27, 2026
Archaeopteryx
added a commit
that referenced
this pull request
May 27, 2026
Collaborator
|
The change has been reverted. There was no noticeable improvement on staging, 80% of the tasks checked had a mismatch of the lines. The issue persists after the revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
urllib3to2.6.3(from1.26.18in production deps and2.0.3in dev deps), moving production onto the actively-maintained 2.x line.Log parser fixture regeneration
urllib3 2.x changes how gzip
Content-Encodingis decompressed during streaming, which shifts line boundaries in the log parser's output. The parsed error content is identical — only the recordedline_numberoffsets change. Nine.logview.jsonfixtures are regenerated to match; the other sample logs were unaffected.Downstream impact
The stored
line_numberis used by the logviewer to position the error-line highlight and the "jump to first error" scroll. Other consumers (bug suggestions, failure classification, push-health matching) key off the error text, not the line number, and thenew_failuretagging match is self-consistent under a uniform shift — so the user-visible effect is confined to where the logviewer highlight lands.Testing
pytest tests/log_parser/→ 146 passed with urllib3 2.6.3 installed.