Skip to content

Upgrade urllib3 to 2.6.3#9556

Merged
Archaeopteryx merged 1 commit into
masterfrom
camd/urllib3-standalone
May 27, 2026
Merged

Upgrade urllib3 to 2.6.3#9556
Archaeopteryx merged 1 commit into
masterfrom
camd/urllib3-standalone

Conversation

@camd
Copy link
Copy Markdown
Collaborator

@camd camd commented May 25, 2026

Summary

Upgrades urllib3 to 2.6.3 (from 1.26.18 in production deps and 2.0.3 in dev deps), moving production onto the actively-maintained 2.x line.

Log parser fixture regeneration

urllib3 2.x changes how gzip Content-Encoding is decompressed during streaming, which shifts line boundaries in the log parser's output. The parsed error content is identical — only the recorded line_number offsets change. Nine .logview.json fixtures are regenerated to match; the other sample logs were unaffected.

Downstream impact

The stored line_number is used by the logviewer to position the error-line highlight and the "jump to first error" scroll. Other consumers (bug suggestions, failure classification, push-health matching) key off the error text, not the line number, and the new_failure tagging match is self-consistent under a uniform shift — so the user-visible effect is confined to where the logviewer highlight lands.

Testing

  • pytest tests/log_parser/146 passed with urllib3 2.6.3 installed.
  • Negative control: running the same fixtures against urllib3 1.26.18 fails on exactly the 9 regenerated fixtures (line-number mismatches), confirming the fixtures correctly track 2.x behavior.

urllib3 2.x changes how gzip content-encoding is decompressed during streaming, which shifts line boundaries in the log parser's output. The parsed content is identical — only the line-number offsets differ.

Regenerated all 16 .logview.json test fixtures to match urllib3 2.x decompression behavior.
@camd camd self-assigned this May 25, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.94%. Comparing base (c661d06) to head (23475d6).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #9556    +/-   ##
========================================
  Coverage   82.94%   82.94%            
========================================
  Files         613      613            
  Lines       35372    35372            
  Branches     3263     3269     +6     
========================================
  Hits        29338    29338            
- Misses       5665     5880   +215     
+ Partials      369      154   -215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archaeopteryx Archaeopteryx merged commit 20cf163 into master May 27, 2026
7 checks passed
@Archaeopteryx Archaeopteryx deleted the camd/urllib3-standalone branch May 27, 2026 15:57
Archaeopteryx added a commit that referenced this pull request May 27, 2026
@Archaeopteryx Archaeopteryx restored the camd/urllib3-standalone branch May 27, 2026 17:05
@Archaeopteryx
Copy link
Copy Markdown
Collaborator

The change has been reverted. There was no noticeable improvement on staging, 80% of the tasks checked had a mismatch of the lines. The issue persists after the revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants