fix(browser): degrade gracefully when Playwright is unavailable#483
Open
kvandre12-commits wants to merge 1 commit into
Open
fix(browser): degrade gracefully when Playwright is unavailable#483kvandre12-commits wants to merge 1 commit into
kvandre12-commits wants to merge 1 commit into
Conversation
Importing the browser stack hard-failed with ModuleNotFoundError: No module named 'playwright' on any environment without a Playwright wheel (e.g. Termux/Android, or a minimal install), which took down the whole app at import time. Wrap the playwright.async_api import in try/except: when present it's an unchanged no-op (real types bind); when absent, bind the type names to Any and install a tiny runtime stub module so the other browser tool modules stay importable. Browser tools raise a clear, friendly error only if actually invoked without Playwright. Tested on Android/Termux (no Playwright): 'import code_puppy.tools' now succeeds where it previously crashed; no change when Playwright is installed.
Author
|
fix(browser): degrade gracefully when Playwright is unavailable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing the browser stack hard-failed with ModuleNotFoundError: No module named 'playwright' on any environment without a Playwright wheel (e.g. Termux/Android, or a minimal install), which took down the whole app at import time.
Wrap the playwright.async_api import in try/except: when present it's an unchanged no-op (real types bind); when absent, bind the type names to Any and install a tiny runtime stub module so the other browser tool modules stay importable. Browser tools raise a clear, friendly error only if actually invoked without Playwright.
Tested on Android/Termux (no Playwright): 'import code_puppy.tools' now succeeds where it previously crashed; no change when Playwright is installed.