Support 24-bit RGB/BGR raw pixel data on iOS#160
Open
mrousavy wants to merge 2 commits into
Open
Conversation
UIImage(fromRawPixelData:) hardcoded 4 bytes per pixel, so loading a 3-byte RGB or BGR buffer computed the wrong bytesPerRow and failed to build a CGImage. Use a native 24-bit CGImage for RGB, and expand BGR to BGRX first (Core Graphics has no 24-bit BGR format). The initializer now derives bytes per pixel from the resolved pixel format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
UIImage(fromRawPixelData:)hardcoded 4 bytes per pixel, so loading a 3-byteRGBorBGRbuffer computedbytesPerRowaswidth * 4against awidth * height * 3buffer and failed to create aCGImage.Fix
CGImageforRGB.BGRtoBGRXfirst, because Core Graphics has no 24-bit BGR format.🤖 Generated with Claude Code