feat: update Windows OS to Server 2025 in 101-managed-vm template - #2
Open
msalsouri wants to merge 1 commit into
Open
feat: update Windows OS to Server 2025 in 101-managed-vm template#2msalsouri wants to merge 1 commit into
msalsouri wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Windows Server image SKU in the ARM template to 2025-datacenter-azure-edition. Feedback highlights that this is a breaking change because the new SKU is Gen2-only, which is incompatible with existing Gen1 deployments. The reviewer also noted potential compatibility issues with the current API version, suggested enabling cloud-optimized features like Hotpatching, and recommended using PascalCase for the SKU name to maintain consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize the Windows Server image from 2016 (EOL approach) to 2025 (current LTS). Uses 'Windows Server 2025 - Azure Edition' SKU for optimal cloud integration.