Skip to content

feat(sidebar): add unfolder and confirmed folder deletion - #45

Merged
moonrailgun merged 1 commit into
mainfrom
ntabbar-unfold
Aug 7, 2026
Merged

feat(sidebar): add unfolder and confirmed folder deletion#45
moonrailgun merged 1 commit into
mainfrom
ntabbar-unfold

Conversation

@moonrailgun

Copy link
Copy Markdown
Contributor

Background

Folder deletion previously overlapped with stale-tab cleanup semantics. This change separates releasing tabs from destructive folder deletion and makes deletion confirmation apply consistently to every folder.

Changes

  • Add a uniform folder context menu with Rename, Unfolder, and Delete Folder actions.
  • Implement Unfolder to remove a folder while keeping child tabs open in place.
  • Replace stale-only cleanup with a generic Delete Folder confirmation dialog that closes current child tabs before deleting the folder.
  • Persist folder deletion only after confirmed child tabs actually close, preserving folders when closes are cancelled.
  • Update localized strings, feature docs, checklist coverage, WebUI tests, and browser dialog coverage.

Testing

Patch includes updated WebUI tests for folder model, sidebar app, and tab list behavior, plus browser test coverage for the native delete-folder dialog.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@moonrailgun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bbcb0814-0b3f-477c-ad07-1334b7bdadc7

📥 Commits

Reviewing files that changed from the base of the PR and between 9eed4ca and 58b352d.

📒 Files selected for processing (15)
  • docs/feature-checklist.md
  • docs/features.md
  • src/dao/browser/strings/dao_strings.grd
  • src/dao/browser/strings/translations/dao_strings_zh-CN.xtb
  • src/dao/browser/ui/views/dao_browser_browsertest.cc
  • src/dao/browser/ui/webui/dao_sidebar_ui.cc
  • src/dao/browser/ui/webui/dao_sidebar_ui.h
  • src/dao/browser/ui/webui/resources/sidebar/__tests__/folder_model.test.ts
  • src/dao/browser/ui/webui/resources/sidebar/__tests__/sidebar_app.test.ts
  • src/dao/browser/ui/webui/resources/sidebar/__tests__/tab_list.test.ts
  • src/dao/browser/ui/webui/resources/sidebar/dao_folder_model.ts
  • src/dao/browser/ui/webui/resources/sidebar/dao_sidebar_app.ts
  • src/dao/browser/ui/webui/resources/sidebar/dao_tab_list.ts
  • src/dao/browser/ui/webui/resources/sidebar/sidebar_bridge.ts
  • src/patches/ui/views/widget/widget_delegate.h.patch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@moonrailgun
moonrailgun merged commit 3229b54 into main Aug 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant