Skip to content

generatemutfasta 1.3: multi-transcript neoantigen peptides + resilience fixes#251

Closed
johnoooh wants to merge 5 commits into
developfrom
feature/generatemutfasta
Closed

generatemutfasta 1.3: multi-transcript neoantigen peptides + resilience fixes#251
johnoooh wants to merge 5 commits into
developfrom
feature/generatemutfasta

Conversation

@johnoooh

Copy link
Copy Markdown
Collaborator

Adds generatemutfasta/1.3 with a --multi_transcript mode that builds neoantigen peptides for alternate transcripts from Genome Nexus' Additional_Transcripts column (-m extended).

Changes

  • New optional outputs: alt_mut_fasta, alt_wt_fasta, transcript_map (only when --multi_transcript is set).
  • Additional_Transcripts parser (field order Transcript_ID,Hugo_Symbol,HGVSp_Short,HGVSc,Variant_Classification; MAF Variant_Classification vocabulary); canonical transcript emitted from the main MAF columns.
  • Primary-path resilience (from a large production run): per-variant try/except skip+count; versionless offline HGVSc requery; guard on missing protein consequence.

Tests

  • pytest 41/41 on the parser + resilience logic.
  • nf-test 3/3 with --profile docker (real-data + two stub tests incl. --multi_transcript).

Notes

  • Container reused: neoantigen-utils-base:1.4.0 (no new image).
  • nf-core lint shows 2 failures + 2 warnings that are byte-identical on the existing 1.2 module (meta-name/process-name convention; test-tag guidelines; ghcr unreachable) — carried over at 1.2 parity, not introduced here.
  • Real-data --multi_transcript nf-test data is deferred until Genome Nexus -m extended output is released (stub + unit coverage in the meantime).

johnoooh added 5 commits July 22, 2026 11:19
- wrap per-variant loop in try/except (skip+count a failing variant, n_errored)
- versionless offline requery for full-form HGVSc (zero-network cache resolve)
- guard missing protein consequence -> warn+skip instead of KeyError
- drop leftover debug print
Adds 3 unit tests (pytest 41/41). nf-test 3/3, snapshot unchanged.
@johnoooh
johnoooh requested review from a team and nikhil as code owners July 22, 2026 20:00
@johnoooh

Copy link
Copy Markdown
Collaborator Author

Closing in favor of extracting the generateMutFasta script + its test suite into its own standalone Python package repository (with proper CI), rather than carrying it as resources/usr/bin inside the module. The nf-core module will be revisited to install the packaged script into the container. Branch feature/generatemutfasta is retained for reference.

@johnoooh johnoooh closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant