one_d4: a request body that is not JSON, or the wrong shape, is a 400 - #1480
Merged
Conversation
Micronaut's JsonSyntaxException and Jackson's DatabindException reach the error handler and answer in the same error envelope as a bad query, with a fixed message rather than the parser's byte offsets. Pinned at the wire.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 4e5f031 | Commit Preview URL Branch Preview URL |
Sep 02 2026, 04:20 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ast-lol | 4e5f031 | Commit Preview URL Branch Preview URL |
Sep 02 2026, 04:26 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1472. A body that isn't JSON, or is JSON of the wrong shape (a string where a number goes), came back as a 500 with a stack trace and a Sentry event per client typo. Both now answer 400 in the same
{"error": …}envelope as a bad query, with a fixed message rather than the parser's byte offsets. Pinned at the wire in QueryErrorWireTest;bazel test //domains/games/apis/one_d4/...passes.