[checkbox] Fix parent group cancellation and indeterminate state#4941
Open
atomiks wants to merge 1 commit into
Open
[checkbox] Fix parent group cancellation and indeterminate state#4941atomiks wants to merge 1 commit into
atomiks wants to merge 1 commit into
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,131.04 ms -205.69 ms(-15.4%) | Renders: 50 (+0) | Paint: 1,701.59 ms -331.97 ms(-16.3%)
10 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8c907e5 to
75a45cc
Compare
75a45cc to
5356871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Checkbox and CheckboxGroup edge cases where internal handling could continue after a canceled change, or manually indeterminate parent checkboxes could expose the wrong state.
Changes
onCheckedChangecancellation run before CheckboxGroup parent/child handling.indeterminatestate to ARIA and the hidden input state.spanroot.Original findings addressed
aria-checked="false".eventDetails.cancel()was too late for parent-enabled CheckboxGroup changes.