Skip to content

[internal] Remove dead popup focus and dismiss paths#4945

Draft
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/popup-focus-dismiss-cleanup
Draft

[internal] Remove dead popup focus and dismiss paths#4945
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/popup-focus-dismiss-cleanup

Conversation

@atomiks
Copy link
Copy Markdown
Contributor

@atomiks atomiks commented May 29, 2026

This removes unused popup focus and dismiss code paths.

Changes

  • Removed the unused referencePressEvent option path from useDismiss.
  • Removed the unused FloatingFocusManager custom order branch.
  • Removed unused markOthers support for inert, markerIgnoreElements, and supportsInert.

Bundle size

Measured with pnpm size:snapshot.

Entrypoint Parsed Gzip
@base-ui/react/context-menu -457 B -183 B
@base-ui/react/menu -455 B -182 B
@base-ui/react/alert-dialog -451 B -177 B
@base-ui/react/autocomplete -440 B -177 B
@base-ui/react/combobox -445 B -168 B
@base-ui/react/select -457 B -166 B
@base-ui/react/popover -452 B -163 B
@base-ui/react/dialog -451 B -160 B
@base-ui/react/drawer -455 B -152 B
@base-ui/react -455 B -146 B
@base-ui/react/navigation-menu -100 B -68 B
@base-ui/react/tooltip -107 B -58 B
@base-ui/react/preview-card -110 B -53 B

@atomiks atomiks changed the title [floating-ui] Remove dead popup focus and dismiss paths [internal] Remove dead popup focus and dismiss paths May 29, 2026
@atomiks atomiks added the internal Behind-the-scenes enhancement. Formerly called “core”. label May 29, 2026 — with ChatGPT Codex Connector
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

commit: 16d7174

@code-infra-dashboard
Copy link
Copy Markdown

code-infra-dashboard Bot commented May 29, 2026

Bundle size

Bundle Parsed size Gzip size
@base-ui/react ▼-442B(-0.09%) ▼-176B(-0.12%)

Details of bundle changes

Performance

Total duration: 1,129.13 ms +31.10 ms(+2.8%) | Renders: 50 (+0) | Paint: 1,710.92 ms +40.95 ms(+2.5%)

No significant changes — details


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 29, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 16d7174
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a19784cb0e76e0008bf7ea3
😎 Deploy Preview https://deploy-preview-4945--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant