Fix base58 encoding losing leading zero bytes#48
Open
sumanjeet0012 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35
This PR fixes the issue where
BaseStringConvertersilently drops leading\x00bytes during encoding and decoding for integer-based encodings (likebase58btc). It now properly counts and preserves them by utilizing the encoding alphabet's zero character.Changes made:
BaseStringConverter.encode()anddecode()to manually handle leading zero bytes.Base16StringConverter.decode()to usebytes.fromhex()directly to bypass the zero-counting logic, as base16 operates byte-by-byte.base58btc,base58flickr,base32z,base36,base10,base8, andbase2with leading zero byte strings to ensure correct round-tripping.All 287 tests pass successfully.