Skip to content

Fix three bugs in one error message...#52

Merged
LourensVeen merged 1 commit into
developfrom
issue_49_broken_error_message
Jun 1, 2026
Merged

Fix three bugs in one error message...#52
LourensVeen merged 1 commit into
developfrom
issue_49_broken_error_message

Conversation

@LourensVeen
Copy link
Copy Markdown
Contributor

@LourensVeen LourensVeen commented May 30, 2026 •
edited
Loading

  • Count was always 0 because we update the length when truncating
  • The implementation object was printed, rather than its name
  • There was an f-string without the f, and that's perfectly fine syntactically but not what I meant

Addresses #49

@LourensVeen LourensVeen requested a review from maarten-ic May 30, 2026 18:38
@LourensVeen LourensVeen self-assigned this May 30, 2026
maarten-ic
maarten-ic approved these changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😅

@LourensVeen LourensVeen merged commit 2f41691 into develop Jun 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maarten-ic maarten-ic maarten-ic approved these changes

Assignees

@LourensVeen LourensVeen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LourensVeen @maarten-ic