Skip to content

🚸 Provide CMake presets#1660

Draft
denialhaag wants to merge 9 commits intomainfrom
cmake-presets
Draft

🚸 Provide CMake presets#1660
denialhaag wants to merge 9 commits intomainfrom
cmake-presets

Conversation

@denialhaag
Copy link
Copy Markdown
Member

Description

This PR defines CMake presets and updates the CI to utilize them.

Fixes #1622

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Apr 23, 2026
@denialhaag denialhaag added usability Anything related to usability c++ Anything related to C++ code labels Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread CMakePresets.json
Comment on lines +8 to +11
"cacheVariables": {
"MLIR_DIR": "$env(MLIR_DIR)",
"LLVM_DIR": "$env(LLVM_DIR)"
}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burgholzer, I don't really see a better option than this. In FullStaQD/compiler, we do provide paths here, but they are only guaranteed to be valid when using the development container, which doesn't really make the presets generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code usability Anything related to usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚸 Adopt CMake presets and devcontainers

1 participant