Skip to content

fix: add missing types for new maxReconnectAttempts - #1348

Open
spuppo-mux wants to merge 2 commits into
muxinc:mainfrom
spuppo-mux:fix/maxReconnectRetries-react-type
Open

fix: add missing types for new maxReconnectAttempts#1348
spuppo-mux wants to merge 2 commits into
muxinc:mainfrom
spuppo-mux:fix/maxReconnectRetries-react-type

Conversation

@spuppo-mux

@spuppo-mux spuppo-mux commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Follow up for the work done in #1344

It was missing adding the new prop type to different React/Astro packages. While this is not released, using the property should still work, so it's safe to ignore the error temporarily.

Edit: accidentally overwrote Cursor summary while editing the description so adding from edit history

Low Risk
Type-only and demo changes; runtime behavior was already supported on the underlying player.

Overview
Follow-up typing for network reconnect support added in an earlier PR: exposes maxReconnectRetries on the public TypeScript and PropTypes surfaces so consumers no longer get type errors when passing the option through React or Astro wrappers.

Adds optional maxReconnectRetries?: number to MuxPlayerProps in @mux/mux-player-react and @mux/mux-player-astro, and maxReconnectRetries: PropTypes.number on mux-video-react. The Next.js MuxPlayer demo wires the prop through default state, the player instance, and a numeric control (documented as 0/unset = off).

Reviewed by Cursor Bugbot for commit 0cf799a. Bugbot is set up for automated code reviews on this repo. Configure here.

@spuppo-mux
spuppo-mux requested a review from a team as a code owner July 24, 2026 21:04
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io

snyk-io Bot commented Jul 24, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
elements-demo-astro Ready Ready Preview Jul 30, 2026 7:52pm
elements-demo-nextjs Ready Ready Preview Jul 30, 2026 7:52pm
elements-demo-svelte-kit Ready Ready Preview Jul 30, 2026 7:52pm
elements-demo-vanilla Ready Ready Preview Jul 30, 2026 7:52pm
elements-demo-vue Ready Ready Preview Jul 30, 2026 7:52pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant