Updated binds with descriptions, modified bind parse logic#1605
Closed
hurlbutt wants to merge 3 commits into
Closed
Updated binds with descriptions, modified bind parse logic#1605hurlbutt wants to merge 3 commits into
hurlbutt wants to merge 3 commits into
Conversation
322d3fa to
77e95ff
Compare
Owner
|
Can you check the latest commit to the lua-migration branch? I have added already the description to all binds. Will update today the rofi keybinding overview script. |
Contributor
Author
|
@mylinuxforwork - I can look through them to see if there are any functional differences and resolve them. Style-wise do you prefer just a single space between parameters or do you want the parameters indented to match vertically? Single spaceVertically aligned |
Owner
|
I have implemented both already in the lua-migration branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes bind descriptions a property of the bind object instead of a lua comment. In addition, created a (temporary) new script file for keybind descriptions that uses
hyprctl bindsandjqto create the keybind string.Changes
How Has This Been Tested?
Checklist
Please ensure your pull request meets the following requirements: