Potential fix for code scanning alert no. 1: Arbitrary file access during archive extraction ("Zip Slip")#2
Closed
myworkside wants to merge 22 commits into
Closed
Potential fix for code scanning alert no. 1: Arbitrary file access during archive extraction ("Zip Slip")#2myworkside wants to merge 22 commits into
myworkside wants to merge 22 commits into
Conversation
Added comprehensive documentation for the Universal File Editor & Viewer application, detailing features, technology stack, project structure, installation instructions, development guide, common issues, roadmap, contributing guidelines, and licensing.
Added Instagram support link for updates and support.
Bumps the gradle group with 2 updates in the / directory: org.apache.poi:poi-ooxml and [com.github.junrar:junrar](https://github.com/junrar/junrar). Updates `org.apache.poi:poi-ooxml` from 5.2.5 to 5.5.1 Updates `com.github.junrar:junrar` from 7.5.5 to 7.5.10 - [Release notes](https://github.com/junrar/junrar/releases) - [Changelog](https://github.com/junrar/junrar/blob/master/CHANGELOG.md) - [Commits](junrar/junrar@v7.5.5...v7.5.10) --- updated-dependencies: - dependency-name: org.apache.poi:poi-ooxml dependency-version: 5.5.1 dependency-type: direct:production dependency-group: gradle - dependency-name: com.github.junrar:junrar dependency-version: 7.5.10 dependency-type: direct:production dependency-group: gradle ... Signed-off-by: dependabot[bot] <support@github.com>
Removed link for LATEST V2.0 APK download from README.
…56a3 Bump the gradle group across 1 directory with 2 updates
Everything up-to-date
…ring archive extraction ("Zip Slip")
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/myworkside/UniversalFileEditorViewer/security/code-scanning/1
To fix this safely, validate the destination path after resolving it and normalizing/canonicalizing, and ensure it stays inside
targetDirbefore writing. Do this for both ZIP and RAR branches, right whereoutFileis created (lines around 63 and 74).Best approach here without changing functionality:
ArchiveRepository:targetDir.child.toPath().startsWith(targetDir.toPath()).SecurityExceptionif invalid.File(targetDir, ...)creation in both extraction branches with this helper.This keeps behavior intact while adding robust containment validation required to prevent Zip Slip style path abuse.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.