-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Replace sync normalized-data with async flow (API-432) #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hilnius
merged 2 commits into
main
from
robinnicollet/api-432-sample-app-replace-sync-normalized-data-with-async-flow
Jul 17, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| export type AsyncJobStatus = "ONGOING" | "SUCCEEDED" | "FAILED"; | ||
|
|
||
| export interface AsyncJob<TPayload = unknown> { | ||
| id: string; | ||
| status: AsyncJobStatus; | ||
| payload?: TPayload; | ||
| } | ||
|
|
||
| const DEFAULT_POLL_INTERVAL_MS = 10 * 1_000; | ||
| const DEFAULT_TIMEOUT_MS = 5 * 60 * 1_000; | ||
|
|
||
| export async function pollUntilSucceeded<TPayload>( | ||
| fetchJob: () => Promise<AsyncJob<TPayload>>, | ||
| options: { intervalMs?: number; timeoutMs?: number } = {}, | ||
| ): Promise<TPayload> { | ||
| const intervalMs = options.intervalMs ?? DEFAULT_POLL_INTERVAL_MS; | ||
| const timeoutMs = options.timeoutMs ?? DEFAULT_TIMEOUT_MS; | ||
| const deadline = Date.now() + timeoutMs; | ||
|
|
||
| while (true) { | ||
| await sleep(intervalMs); | ||
|
|
||
| if (Date.now() >= deadline) { | ||
| throw new Error(`Did not get results within ${timeoutMs}ms. Aborting polling.`); | ||
| } | ||
|
|
||
| const job = await fetchJob(); | ||
|
|
||
| if (job.status === "SUCCEEDED") { | ||
| if (job.payload === undefined) { | ||
| throw new Error("Async job succeeded but returned no payload."); | ||
| } | ||
| return job.payload; | ||
| } | ||
|
|
||
| if (job.status === "FAILED") { | ||
| throw new Error(`Async job ${job.id} failed.`); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function sleep(ms: number): Promise<void> { | ||
| return new Promise((resolve) => setTimeout(resolve, ms)); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeout check before fetch discards completed results
Medium Severity
The deadline check on line 23 runs after
sleepbut beforefetchJob, so when the timeout expires, the function throws without making one final status check. If the async job completed during the last sleep interval,pollUntilSucceededreports a spurious timeout instead of returning the successful result. Moving the deadline check after thefetchJobcall (or after the status checks) would avoid discarding a ready result.Reviewed by Cursor Bugbot for commit 7d43ecc. Configure here.