test(serve): align Windows schema tests with current contracts - #5
Open
Apoze wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(serve): align Windows schema tests with current contracts
Problem
ninfer_openai_schema_testno longer matched three contracts already implemented by the Windowsserver branch:
ninfernamespace;enable_thinking=falseandreasoning_effort=lowis rejected by the request parser,before prompt semantics are resolved; and
/propsexposesn_ctxdirectly underdefault_generation_settings, not underparams.The stale assertions caused a compile failure followed by a failing schema test even though the
server behavior was correct.
Design and affected behavior
Update only
tests/test_openai_schema.cppto assert the current parser and/propscontracts andto use the fully qualified enum. No serving, inference, model, sampling, CUDA, or public protocol
behavior changes.
Verification
Windows 11, MSVC 19.39 / Visual Studio Build Tools 2022, CUDA 13.1, RTX 5090:
Result: target built successfully.
Result:
1/1passed.Result: passed with no output.
The full suite was not rerun because this is a test-only correction in one translation unit and
does not change production code.
AI disclosure
The implementation was produced with OpenAI GPT-5.6 Sol (Codex, xhigh reasoning). I reviewed the
complete diff, verified each assertion against the current implementation, and ran the focused
Windows build and test above.