add an option to prefix names of generated client/server types - #71
Open
propan wants to merge 2 commits into
Open
add an option to prefix names of generated client/server types#71propan wants to merge 2 commits into
propan wants to merge 2 commits into
Conversation
Member
|
This is a nice addition to nrpc, thanks! To be merged, we need a demonstration in an example (can be alloptions), and since I just updated the dependencies in the master branch, a rebase keeping only the new feature. Also, I think it is not prefixing all the types, at least the "xxxHandler" type is not. Thanks for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
We use proto-generators extensively in our code base and the generated types collide with some existing types, it would be convenient to have an option to prefix generated client/server type name like:
With these changes, the default behaviour stays the same.
It would be great to get it merged!
Thanks.