Skip to content

add an option to prefix names of generated client/server types - #71

Open
propan wants to merge 2 commits into
nats-rpc:masterfrom
noice-com:master
Open

add an option to prefix names of generated client/server types#71
propan wants to merge 2 commits into
nats-rpc:masterfrom
noice-com:master

Conversation

@propan

@propan propan commented Feb 14, 2023

Copy link
Copy Markdown

Hi!

We use proto-generators extensively in our code base and the generated types collide with some existing types, it would be convenient to have an option to prefix generated client/server type name like:

option (nrpc.typesPrefix) = "NRPC";

With these changes, the default behaviour stays the same.

It would be great to get it merged!

Thanks.

@cdevienne

Copy link
Copy Markdown
Member

This is a nice addition to nrpc, thanks!

To be merged, we need a demonstration in an example (can be alloptions), and since I just updated the dependencies in the master branch, a rebase keeping only the new feature.

Also, I think it is not prefixing all the types, at least the "xxxHandler" type is not.

Thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants