-
Notifications
You must be signed in to change notification settings - Fork 5
feat(connectors): add AsyncDBConnectorProtocol; implement on PostgreSQL and SQLite #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kurodo3
wants to merge
19
commits into
main
Choose a base branch
from
eywalker/plt-1453-add-async-methods-to-dbconnectorprotocol-implement-across
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a6be594
docs(specs): add async DB connector protocol design spec for PLT-1453
kurodo3[bot] e48eef7
docs(specs): defer SpiralDB async to PLT-1456; narrow PLT-1453 scope
kurodo3[bot] 05cfd72
docs(plans): add async DB connector implementation plan (PLT-1453)
kurodo3[bot] f105777
feat(protocols): add AsyncDBConnectorProtocol (PLT-1453)
kurodo3[bot] ac37073
refactor(protocols): fix AsyncDBConnectorProtocol quality issues (PLT…
kurodo3[bot] b0105a9
feat(postgresql): add async lifecycle methods (PLT-1453)
kurodo3[bot] e08cf2a
refactor(postgresql): document async lifecycle; fix pytest asyncio co…
kurodo3[bot] eacbe2e
feat(postgresql): add async schema introspection methods (PLT-1453)
kurodo3[bot] 37060cc
refactor(postgresql): improve async schema test coverage and docstrin…
kurodo3[bot] 0546ae2
feat(postgresql): add async_iter_batches (PLT-1453)
kurodo3[bot] 937cea8
refactor(postgresql): fix async_iter_batches comment; improve test cl…
kurodo3[bot] b08fd3d
feat(sqlite): add async methods via asyncio.to_thread() (PLT-1453)
kurodo3[bot] 68ce5db
refactor(sqlite): enrich async method docstrings (PLT-1453)
kurodo3[bot] c6db94a
test(postgresql): add async integration tests (PLT-1453)
kurodo3[bot] 6ae4d97
refactor(test): remove unused asyncio import in pg integration tests …
kurodo3[bot] 182a3c8
fix(test): compute sync results before entering async context manager
kurodo3[bot] 3e8445a
docs(spec): clarify async_iter_batches materialises full result befor…
kurodo3[bot] c0daf87
fix(postgresql): avoid blocking event loop in async_close and async_i…
kurodo3[bot] 9d3ddbc
refactor(connectors): address PR review — consolidate SQL/query logic…
kurodo3[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`asyncio_default_fixture_loop_scope = function` tells pytest-asyncio to create a fresh event loop for each test function. Without it, pytest-asyncio ≥ 0.23 emits a `DeprecationWarning` and will error in a future release. The `function` scope is the strictest setting — it prevents any async state from leaking between tests.