-
Notifications
You must be signed in to change notification settings - Fork 5
feat(types): UUID Arrow type migration — pa.binary(16) for all UUID storage (PLT-1162) #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kurodo3
wants to merge
26
commits into
main
Choose a base branch
from
eywalker/plt-1162-design-spike-uuid-arrow-type-mapping-large_string-vs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d5b488f
docs(types): add UUID Arrow type mapping design spec (PLT-1162)
kurodo3[bot] 1cca130
docs(plans): add UUID Arrow type implementation plan (PLT-1162)
kurodo3[bot] 045803c
feat(types): add UUID_ARROW_TYPE and UUID_STRUCT_ARROW_TYPE constants…
kurodo3[bot] eaa27c2
fix(types): make UUID_ARROW_TYPE and UUID_STRUCT_ARROW_TYPE truly laz…
kurodo3[bot] 400c000
feat(semantic-types): add UUIDStructConverter for uuid.UUID Arrow str…
kurodo3[bot] 52b9695
fix(semantic-types): add missing protocol methods to UUIDStructConver…
kurodo3[bot] cad5ccf
feat(semantic-types): register UUIDStructConverter in default semanti…
kurodo3[bot] 503b730
fix(hashing): UUIDHandler returns bytes instead of str, consistent wi…
kurodo3[bot] 7b3101f
docs(hashing): fix stale UUIDHandler docstring; add missing test docs…
kurodo3[bot] e353f21
fix(arrow): update system UUID column Arrow types to pa.binary(16) (P…
kurodo3[bot] e391011
fix(core): correct stale comment and rid_val bytes fallback after UUI…
kurodo3[bot] 19a977a
fix(core): UUID generation sites produce bytes instead of str (PLT-1162)
kurodo3[bot] 7301a8e
fix(databases): map PostgreSQL uuid columns to UUID_ARROW_TYPE (pa.bi…
kurodo3[bot] 0c922b7
docs(types): add PLT-1615 cross-reference in UUID Arrow type spec (PL…
kurodo3[bot] 13a1d5a
refactor(types): address PR review — drop UUID constants, uuid.UUID d…
kurodo3[bot] 74f36d8
fix(uuid): migrate record IDs to pa.large_binary(); add ContentHash.t…
kurodo3[bot] abea56e
fix(ci): resolve two CI failures — bytes record IDs and PostgreSQL UU…
kurodo3[bot] 6155f75
refactor(databases): coerce str record IDs to bytes at method boundaries
kurodo3[bot] 282afb9
refactor(databases): revert str coercion from protocol — concrete imp…
kurodo3[bot] 246e5d5
refactor(databases): rename _utils.py → utils.py
kurodo3[bot] e0bbc37
refactor(databases): use pa.binary(16) for UUID/record-id columns, dr…
kurodo3[bot] 87ae2e9
refactor(datagrams): rename datagram_id → datagram_uuid for clarity
kurodo3[bot] d0cbe5a
fix(sources,databases): resolve Copilot review issues — ambiguous UUI…
kurodo3[bot] b9a6934
revert(sources): restore original UUIDv5 name format in _make_record_id
kurodo3[bot] 62c8f88
refactor(datagrams,semantic-types): address eywalker review — naming,…
kurodo3[bot] 2fab1b8
refactor(semantic-types): remove add_prefix from hash_struct_dict
kurodo3[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,3 +40,5 @@ | |
| "streams", | ||
| "types", | ||
| ] | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include tests to ensure that the removal force convresion into
stris not creating a new error?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Added in . It iterates over all system-tag columns in the predicted schema after a two-way join and asserts that record_id columns map to (from ) and source_id columns map to — verifying that is carried through unchanged.