use npe2 ConfigurationContribution for settings, with fallback - #71
Open
TimMonko wants to merge 10 commits into
Open
use npe2 ConfigurationContribution for settings, with fallback#71TimMonko wants to merge 10 commits into
TimMonko wants to merge 10 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
napari/napari#9308
napari/npe2#502
Description
This PR demonstrates using napari/npe2's configuration in the napari.yaml manifest for settings management and ripping out ndev-settings.
Unfortunately, it's not quite a "drop-in" PR because I don't want to put a lower pin on napari. Regardless, I need a way to always be looking at napari.yaml (and not ndev-settings.yaml) for settigns, so this PR does consolidate to using a fallback in order to drop ndev-settings. Otherwise it would be really complicated to maintain both ndev-settings and napari config pathways.
Importantly, I used this PR to understand for myself if everything was working and make the documentation (napari/npe2#502).