Expand the shell approval corpus - #1754
Merged
Merged
Conversation
Aaronontheweb
added
tests
Aaronontheweb
commented
Aug 4, 2026
| Bash("git status && git log"), | ||
| Approvals.None, | ||
| ExpectedApproval.Allow(ToolAllowReason.SafeVerbInTrustedScope)), | ||
| Case( |
Collaborator
Author
There was a problem hiding this comment.
these are the types of cases the new shell approval system should be able to auto-approve in 0.26, provided that all of the underlying verbs are approved
Aaronontheweb
commented
Aug 4, 2026
| Approvals.PersistentAnywhere( | ||
| "git add", | ||
| "git commit", | ||
| "netclaw daemon stop", |
Aaronontheweb
commented
Aug 4, 2026
| Approvals.Session("git add", "gh pr merge"), | ||
| Approvals.PersistentHere(ApprovalDirectoryShape.Project, "git commit"), | ||
| Approvals.PersistentAnywhere("git push")), | ||
| ExpectedApproval.Allow( |
Collaborator
Author
There was a problem hiding this comment.
LGTM - approval composed from different sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This precursor PR expands the Bash approval baseline before #1753 changes production behavior.
Coverage
Baseline findings
Scope
This PR changes tests and the review snapshot only. It does not change production behavior or specifications.
Validation
PR #1753 should rebase onto dev after this PR merges.