Include netdata-otel in restarter targets - #525
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Netdata Helm chart’s restarter policy so it also targets the netdata-otel Deployment when OpenTelemetry is enabled.
Changes:
- Add
{{ template "netdata.name" . }}-otelto the restarter Role’s allowedresourceNames. - Include
deployment/<name>-otelin the restarter CronJob’s rollout-restart target list when.Values.netdataOpentelemetry.enabledis true. - Extend
netdata.restarter.enabledto consider.Values.netdataOpentelemetry.enabledas a qualifying workload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/netdata/templates/restarter/role.yml | Allows the restarter to patch/get the *-otel Deployment. |
| charts/netdata/templates/restarter/cronjob.yaml | Adds deployment/*-otel to the rollout restart arguments when OTel is enabled. |
| charts/netdata/templates/_helpers.tpl | Ensures the restarter can be enabled when only netdataOpentelemetry is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilyam8
approved these changes
Apr 2, 2026
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to include netdata-otel in the restarter policy, this is a simple fix for it.