test(config): migrate normalize tests to vitest - #7155
Conversation
Migrates the `normalize.js` tests to vitest. Snapshots have been compared and are equal.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (8)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e18e dependency analysisNo dependency warnings found. |
@netlify/build
@netlify/build-info
@netlify/cache-utils
@netlify/config
@netlify/edge-bundler
@netlify/functions-utils
@netlify/git-utils
@netlify/headers-parser
@netlify/api
@netlify/nock-udp
@netlify/opentelemetry-sdk-setup
@netlify/opentelemetry-utils
@netlify/redirect-parser
@netlify/run-utils
@netlify/zip-it-and-ship-it
commit: |
serhalp
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just one request inline please 🙏🏼
| restoreMocks: true, | ||
| environment: 'node', | ||
| testTimeout: 100_000, | ||
| include: ['tests/**/*.test.js'], |
There was a problem hiding this comment.
I fear we'll quietly not run new/ported tests in the future:
| include: ['tests/**/*.test.js'], | |
| include: ['tests/**/*.test.{js,ts}'], |
| "indent-string": "^5.0.0", | ||
| "is-plain-obj": "^4.0.0", | ||
| "map-obj": "^5.0.0", | ||
| "omit.js": "^2.0.2", |
There was a problem hiding this comment.
🙏🏼 could you split this change out into a separate PR so we can mark it as fix(deps) and keep this one as a pure chore?
This migrates the normalize tests to vitest.
As part of that, it drops
omit.jssince it can't load without some funkiness in vitest and is redundant anyway.The snapshots were diffed locally and appear to be equal (via a script i had claude make).
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)