Skip to content

fix: don't crash the CLI when the upstream dev server dies mid-response #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NMiller3862 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix: don't crash the CLI when the upstream dev server dies mid-response #8386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/utils/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,15 @@ const initializeProxy = async function ({
}

if (res instanceof http.ServerResponse) {
if (res.headersSent || res.writableEnded) {
// The upstream died mid-response: headers are already on the wire, so
// `writeHead` below would throw ERR_HTTP_HEADERS_SENT out of this event
// handler and terminate the whole CLI (see #5917). The response is
// unsalvageable — drop the socket and keep the dev server alive so
// requests after the upstream comes back succeed.
res.destroy()
return
}
res.writeHead(500, {
'Content-Type': 'text/plain',
})
Expand Down