test: allow custom fixture dep overrides - #34
Conversation
✅ Deploy Preview for angular-runtime-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Vite plugin adds package override loading through Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This is needed to be able to add `@netlify/vite-plugin` to vite-ecosystem-ci: vitejs/vite-ecosystem-ci#444.
bb8e079 to
6659056
Compare
| // Vite 8 uses node:util styleText (Node >= 22) | ||
| const supportsVite8 = nodeMajor >= 22 | ||
|
|
||
| describe.for([['5.0.0'], ['6.0.0'], ...(supportsVite7 ? [['7.0.0']] : []), ...(supportsVite8 ? [['8.0.0']] : [])])( |
There was a problem hiding this comment.
Highly recommend "Hide whitespace" here!
This is needed to be able to add
@netlify/vite-pluginto vite-ecosystem-ci: vitejs/vite-ecosystem-ci#444.package.jsoninto the site fixtures where vite/rolldown/etc. are actually used in our plugin's tests.