Skip to content

test: allow custom fixture dep overrides - #34

Open
serhalp wants to merge 1 commit into
mainfrom
serhalp/test/allow-injecting-fixture-pkg-overrides
Open

test: allow custom fixture dep overrides#34
serhalp wants to merge 1 commit into
mainfrom
serhalp/test/allow-injecting-fixture-pkg-overrides

Conversation

@serhalp

@serhalp serhalp commented Aug 6, 2026

Copy link
Copy Markdown
Member

This is needed to be able to add @netlify/vite-plugin to vite-ecosystem-ci: vitejs/vite-ecosystem-ci#444.

  • Allow replacing the Vite version table test array with a single set of custom overrides
  • Copy the overrides that vite-ecosystem-ci injects into our package.json into the site fixtures where vite/rolldown/etc. are actually used in our plugin's tests.

@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for angular-runtime-demo ready!

Name Link
🔨 Latest commit 6659056
🔍 Latest deploy log https://app.netlify.com/projects/angular-runtime-demo/deploys/6a74e8bf647a480008a38f7b
😎 Deploy Preview https://deploy-preview-34--angular-runtime-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 47fb1e9a-5b4a-4b00-a444-c0b88d83b373

📥 Commits

Reviewing files that changed from the base of the PR and between 566da57 and 6659056.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • packages/vite-plugin/package.json
  • packages/vite-plugin/src/main.test.ts
  • packages/vite-plugin/test/support/getPackageOverrides.ts
  • packages/vite-plugin/tsconfig.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Expanded Vite plugin coverage across supported Vite versions and package override scenarios.
    • Added validation for copying package overrides into test fixtures.
  • Chores
    • Added development tooling for package metadata normalization.
    • Updated TypeScript configuration to include test files.

Walkthrough

The Vite plugin adds package override loading through getPackageOverrides(). The test suite replaces its Vite-version matrix with copied fixture overrides and supported Vite 5–8 configurations. Fixture setup across middleware, static files, redirects, Image CDN, functions, edge functions, SPA, Blobs, and React tests now applies the selected overrides. TypeScript compilation now includes test files.

Estimated code review effort: 4 (Complex) | ~45 minutes

Suggested reviewers: pieh, eduardoboucas

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description directly explains custom fixture dependency overrides and their use with vite-ecosystem-ci.
Title check ✅ Passed The title clearly summarizes the main change: support for custom dependency overrides in test fixtures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch serhalp/test/allow-injecting-fixture-pkg-overrides

Comment @coderabbitai help to get the list of available commands.

serhalp added a commit to serhalp/vite-ecosystem-ci that referenced this pull request Aug 6, 2026
This is needed to be able to add `@netlify/vite-plugin` to vite-ecosystem-ci:
vitejs/vite-ecosystem-ci#444.
@serhalp
serhalp force-pushed the serhalp/test/allow-injecting-fixture-pkg-overrides branch from bb8e079 to 6659056 Compare August 6, 2026 20:04
// Vite 8 uses node:util styleText (Node >= 22)
const supportsVite8 = nodeMajor >= 22

describe.for([['5.0.0'], ['6.0.0'], ...(supportsVite7 ? [['7.0.0']] : []), ...(supportsVite8 ? [['8.0.0']] : [])])(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highly recommend "Hide whitespace" here!

serhalp added a commit to serhalp/vite-ecosystem-ci that referenced this pull request Aug 6, 2026
@serhalp
serhalp marked this pull request as ready for review August 6, 2026 20:26
@serhalp
serhalp requested a review from a team as a code owner August 6, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant