Fix update-dependent-repositories-gomod toolchain pin - #97
Merged
Conversation
Dependent repos (sdk-k8s, sdk-kernel, cmd-nsmgr, etc.) will require go >= 1.25.0 once they pull in the current sdk/api uplift (grpc v1.82.1). The bot's setup-go step was pinned to 1.23.3, which fails with: go: go.mod requires go >= 1.25.0 (running go 1.23.3; GOTOOLCHAIN=local) when it runs 'go get -u .../sdk@main' + 'go mod tidy' inside each dependent repo checkout. Bump the pin to 1.25.0 and set GOTOOLCHAIN=auto for the update step so future go directive bumps in any dependent repo don't hard-fail the same way. This mirrors the same fix already applied directly in the api repo's own copy of this workflow (networkservicemesh/api#203). This is a shared @main-referenced workflow, so it takes effect immediately for every consumer (api, sdk, and their dependents) once merged. Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Once
apiandsdkland their grpc v1.82.1 uplift (requiringgo >= 1.25.0), this shared workflow'supdate-dependent-repositoriesjob will fail across every dependent repo in the matrix (
sdk-k8s,sdk-kernel,cmd-nsmgr, etc.) with:when it runs
go get -u .../sdk@main+go mod tidyinside eachcheckout, since the
actions/setup-gostep is pinned to1.23.3withno toolchain auto-upgrade.
Fix
setup-gopin to1.25.0GOTOOLCHAIN=autofor the update step, so futuregodirectivebumps in any dependent repo don't hard-fail the same way — Go will
download whatever toolchain the target module actually needs.
This mirrors the identical fix already applied directly in
api's ownlocal copy of this workflow (networkservicemesh/api#203), and resolves
the same class of failure for
sdk's copy.Scope note
This is a shared
@main-referenced reusable workflow, consumed byapi,sdk, and (viasdk's own workflow) their 13 dependent repos.The change takes effect immediately for all consumers once merged.
No config/behavior change for repos that don't cross the go1.25
threshold.