Draft
Fix Role::users() relationship: use belongsToMany for many-to-many#2
Conversation
Co-authored-by: Blair2004 <5265663+Blair2004@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SQL query for retrieving users by role
Fix Role::users() relationship: use belongsToMany for many-to-many
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Role::users()relationship usedhasManyThroughfor a many-to-many relationship through theusers_roles_relationspivot table.hasManyThroughis designed for indirect relationships (A → B → C), not pivot tables (A ↔ pivot ↔ B).Changes
src/Models/Role.php
users()fromhasManyThrough(User, UserRoleRelation, ...)tobelongsToMany(User, 'users_roles_relations', 'role_id', 'user_id')BelongsToManyreturn typeBefore/After
The generated SQL now correctly joins users through the pivot table. All existing query methods (
get(),count(),where(), etc.) remain compatible.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.