Skip to content

edit tags#16672

Open
tobiasKaminsky wants to merge 11 commits into
masterfrom
editTags
Open

edit tags#16672
tobiasKaminsky wants to merge 11 commits into
masterfrom
editTags

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Mar 13, 2026

Copy link
Copy Markdown
Member

Disclaimer: Claude AI

@github-actions

github-actions Bot commented Mar 13, 2026

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16672.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

alperozturk96
alperozturk96 requested changes Mar 18, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagListAdapter.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagListAdapter.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
.show(fragmentManager, "actions");
}

private void refreshTagChips(Context context) {

@alperozturk96 alperozturk96 Mar 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FileDetailFragment already 900+ lines of code. Let's not make it more harder to maintain. Please create a new Kotlin class and pass reference and handle the refresh tag chips there.

@mpivchev mpivchev mentioned this pull request Mar 24, 2026
Closed
@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24389201000/artifacts/6423672148
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Apr 15, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24439364984/artifacts/6444218935
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky @alperozturk96
edit tags
55e530a 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

# Conflicts:
#	gradle/libs.versions.toml
@tobiasKaminsky @alperozturk96
wip
e62d4ce 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
wip
58b69fb 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@alperozturk96
separate inner classes
a9fe1ea 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove unused error message string
49f1874 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27810774168/artifacts/7743761678
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
codacy fix
cab5121 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use bundle compat
5f37621 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
alperozturk96 requested changes Jun 19, 2026
View reviewed changes

@alperozturk96 alperozturk96 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashing on slow instances due to a socket timeout while fetching tags. Also, when scrolling the adapter, items keep getting swapped or appear in the wrong positions.

Tested with 58b69fb

@alperozturk96
use repository design pattern
24d1e78 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27814668793/artifacts/7745304336
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
wip
d4b1833 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27815183063/artifacts/7745542040
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix tag assigning
768b024 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
924546b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27817456441/artifacts/7746548761
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3333
Correctness6767
Dodgy code214214
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3131
Performance4141
Security1616
Total412412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasKaminsky @alperozturk96