feat: implement automatic creation of .system folder in auto-created team-folder - #5011
Open
Fin-c wants to merge 1 commit into
Open
feat: implement automatic creation of .system folder in auto-created team-folder#5011Fin-c wants to merge 1 commit into
Fin-c wants to merge 1 commit into
Conversation
Fin-c
force-pushed
the
feature/generate_automatic_appdata_Folder
branch
2 times, most recently
from
August 11, 2026 08:59
900b89d to
b91c146
Compare
Fin-c
changed the title
alimmroth
changed the title
mejo-
reviewed
Aug 11, 2026
Fin-c
force-pushed
the
feature/generate_automatic_appdata_Folder
branch
from
August 12, 2026 11:45
b91c146 to
9b6e413
Compare
Co-authored-by: Copilot <copilot@github.com> Assisted-by: GPT-5.3 Codex Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>
Fin-c
force-pushed
the
feature/generate_automatic_appdata_Folder
branch
from
August 17, 2026 14:11
9b6e413 to
c55a419
Compare
Contributor
|
Keep this in mind: nextcloud/server#46309 Meaning that folder must not have team specific contents in root level but should be considered to also contain other apps data to not create more folders like this in the future. |
artonge
reviewed
Aug 19, 2026
Comment on lines
+134
to
+142
| if ($storage->is_dir($path)) { | ||
| return; | ||
| } | ||
|
|
||
| if (!$storage->mkdir($path) && !$storage->is_dir($path)) { | ||
| throw new \RuntimeException("Could not create $path folder for team space"); | ||
| } | ||
|
|
||
| $storage->getScanner()->scan($path); |
Contributor
There was a problem hiding this comment.
@icewind1991 is this the easiest way to go, or is there a better way?
| * | ||
| * @throws \RuntimeException when the directory cannot be created. | ||
| */ | ||
| private function ensureAppDirectory(IStorage $storage, string $path): void { |
Contributor
There was a problem hiding this comment.
Will this ever be used outside of createAppDirectory? If not, maybe we should merge both functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: create an
.systemfolder in the team-folder after creating a team. This hidden folder will hold team-owned app-data in the future.Relates to nextcloud/circles#2637
🤖 AI (if applicable)