fix: update group edit button accessibility and label - #5020
Open
kristian-zendato wants to merge 1 commit into
Open
fix: update group edit button accessibility and label#5020kristian-zendato wants to merge 1 commit into
kristian-zendato wants to merge 1 commit into
Conversation
kristian-zendato
added
3. to review
susnux
reviewed
Aug 14, 2026
Signed-off-by: kristian.zendato <kristian.zendato@nextcloud.com>
kristian-zendato
force-pushed
the
fix/edit-button-label
branch
from
August 14, 2026 10:05
a6ac60b to
1253702
Compare
susnux
approved these changes
Aug 14, 2026
| <a onClick={removeGroup.bind(this, groupId)} className="close-btn"></a> | ||
| <button | ||
| onClick={removeGroup.bind(this, groupId)} | ||
| aria-label={t('groupfolders', 'Unassign: {group}', { group: displayNames[index] })} |
Contributor
There was a problem hiding this comment.
I think its enough here to just label the action
Suggested change
| aria-label={t('groupfolders', 'Unassign: {group}', { group: displayNames[index] })} | |
| aria-label={t('groupfolders', 'Unassign')} |
susnux
reviewed
Aug 14, 2026
| return <a className="action-rename" onClick={showEdit}> | ||
| return <button className="action-rename" | ||
| aria-label={t('groupfolders', 'Edit assigned groups: {groups}', { groups: displayNames.join(', ') })} | ||
| onClick={showEdit}> |
Contributor
There was a problem hiding this comment.
instead of the explicit label that duplicates the concatination logic you can also just add:
<span class="visually-hidden">{t('groupfolders', 'Edit assigned groups:')}</span>
to the button content, then its labelled correctly and you can remove the aria-label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves [a11y] missing label for edit buttons #4467
Make edit button visible when focused not only when hover.
Add label for group edit button
🤖 AI (if applicable)