feat(teamspace): resolve teams for files inside a team folder - #5035
Draft
pringelmann wants to merge 1 commit into
Draft
feat(teamspace): resolve teams for files inside a team folder#5035pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open a team folder in Files and the sidebar shows no team. Same for any file inside it. Circles resolves teams from share rows, but a team folder arrives as a mount, so there is nothing to find.
TeamSpaceProvidernow implementsITeamFileResourceProvider(nextcloud/server#6344):getTeamsForFile()locates the file's group folder through the user mount cache, then returns the circles assigned to it. Works at the mount root and at any depth below it.getTeamsForResource()used to return an empty array. It now answers for a folder id, which is what the Teams app passes.Circles are read from both places a folder can be linked to one:
team_circle_idfor a team space, and circle rows ingroup_folders_groupsfor a regular folder shared with a team.Verified against a team folder root, a nested folder, a circle-shared folder, and an unrelated folder.
Depends on nextcloud/server#63444 and nextcloud/circles#2790.
🤖 AI (if applicable)