fix(files_external): set usePresignedUrl before first S3 connection - #63417
Open
mosi-kha wants to merge 1 commit into
Open
fix(files_external): set usePresignedUrl before first S3 connection#63417mosi-kha wants to merge 1 commit into
mosi-kha wants to merge 1 commit into
Conversation
mosi-kha
requested review from
icewind1991,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
August 19, 2026 14:17
isUsePresignedUrl() was read by preSignedUrl() before getConnection() ever ran, since the flag was only assigned as a side effect inside getConnection(). Any request path that never opens a real S3 client (e.g. a PROPFIND that only reads cached DB metadata) saw the flag stuck at its default false, so downloadURL/download-url-expiration came back empty even with use_presigned_url configured. Move the assignment into parseParams(), which runs at construction time for every S3 backend (primary storage and external storage), so the flag is correct regardless of whether a connection was ever opened. Fixes nextcloud#59249 Signed-off-by: mostafa <mostafakhaki00@gmail.com>
mosi-kha
force-pushed
the
fix/s3-presigned-url-flag-not-set
branch
from
August 19, 2026 14:21
e9f3ec0 to
e914b68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isUsePresignedUrl()could returnfalseeven withuse_presigned_urlconfigured, because the flag was only ever assigned insidegetConnection()— a lazy, on-demand S3 client init.preSignedUrl()checksisUsePresignedUrl()before callinggetConnection(), so on any request path that never opens a real S3 connection first (e.g. a WebDAV PROPFIND fordownloadURLthat only reads cached DB metadata), the flag was stuck at its defaultfalseand the presigned URL silently came back empty.parseParams(), which runs at construction time for both primary S3 storage and S3 external storage, so the flag is correct from the start regardless of connection state.Fixes #59249
Test plan
use_presigned_url => trueon a primary S3 objectstore (or an S3 external storage mount){http://owncloud.org/ns}downloadURLwithout triggering any prior S3 read in the same request