fix: validation message - #63434
Open
kristian-zendato wants to merge 3 commits into
Open
Conversation
kristian-zendato
requested review from
come-nc,
icewind1991,
provokateurin,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
August 20, 2026 11:36
susnux
reviewed
Aug 20, 2026
| type="date" | ||
| @input="onExpirationChange" /> | ||
| @update:model-value="onExpirationChange" | ||
| @change="checkExpirationDateValidity" /> |
Contributor
There was a problem hiding this comment.
I do not this this is needed, it should be enough to check this in saveShare no?
Contributor
Author
There was a problem hiding this comment.
@susnux That makes sense. But here is comment for the issue.
error message is displayed only after clicking update - should be displayed right away
That's why I check the validation on every input.
susnux
reviewed
Aug 20, 2026
Comment on lines
+199
to
+202
| #### DO NOT CHANGE ANYTHING ABOVE THIS LINE #### | ||
|
|
||
| ErrorDocument 403 /server/index.php/error/403 | ||
| ErrorDocument 404 /server/index.php/error/404 |
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
kristian-zendato
force-pushed
the
fix/validation-message
branch
from
August 20, 2026 15:28
d001394 to
fad4041
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves form validation feedback in the following places:
letters, numbers, spaces, and _.@-').min/maxconstraints before saving, report invalid dates with the browser validation UI, and highlight invalid date inputs.Checklist
3. to review, feature component)stable32)AI (if applicable)