fix: Store login name and not uid in session when login with webauthn - #63442
Draft
come-nc wants to merge 1 commit into
Draft
fix: Store login name and not uid in session when login with webauthn#63442come-nc wants to merge 1 commit into
come-nc wants to merge 1 commit into
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
fix/fix-webauthn-loginname
branch
from
August 20, 2026 15:13
091c5e1 to
8641db4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At login, the login name used is kept in session for some usecases later on.
When using WebAuthn, the controller was passing the uid instead of the login name to the rest of the login chain, resulting in wrong information in the session.
Checklist
3. to review, feature component)stable32)AI (if applicable)