Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/composer/composer/autoload_classmap.php
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,7 @@
'OCP\\TaskProcessing\\TaskTypes\\TextToTextSummary' => $baseDir . '/lib/public/TaskProcessing/TaskTypes/TextToTextSummary.php',
'OCP\\TaskProcessing\\TaskTypes\\TextToTextTopics' => $baseDir . '/lib/public/TaskProcessing/TaskTypes/TextToTextTopics.php',
'OCP\\TaskProcessing\\TaskTypes\\TextToTextTranslate' => $baseDir . '/lib/public/TaskProcessing/TaskTypes/TextToTextTranslate.php',
'OCP\\Teams\\ITeamFileResourceProvider' => $baseDir . '/lib/public/Teams/ITeamFileResourceProvider.php',
'OCP\\Teams\\ITeamFolderProvider' => $baseDir . '/lib/public/Teams/ITeamFolderProvider.php',
'OCP\\Teams\\ITeamManager' => $baseDir . '/lib/public/Teams/ITeamManager.php',
'OCP\\Teams\\ITeamResourceProvider' => $baseDir . '/lib/public/Teams/ITeamResourceProvider.php',
Expand Down
1 change: 1 addition & 0 deletions lib/composer/composer/autoload_static.php
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,7 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
'OCP\\TaskProcessing\\TaskTypes\\TextToTextSummary' => __DIR__ . '/../../..' . '/lib/public/TaskProcessing/TaskTypes/TextToTextSummary.php',
'OCP\\TaskProcessing\\TaskTypes\\TextToTextTopics' => __DIR__ . '/../../..' . '/lib/public/TaskProcessing/TaskTypes/TextToTextTopics.php',
'OCP\\TaskProcessing\\TaskTypes\\TextToTextTranslate' => __DIR__ . '/../../..' . '/lib/public/TaskProcessing/TaskTypes/TextToTextTranslate.php',
'OCP\\Teams\\ITeamFileResourceProvider' => __DIR__ . '/../../..' . '/lib/public/Teams/ITeamFileResourceProvider.php',
'OCP\\Teams\\ITeamFolderProvider' => __DIR__ . '/../../..' . '/lib/public/Teams/ITeamFolderProvider.php',
'OCP\\Teams\\ITeamManager' => __DIR__ . '/../../..' . '/lib/public/Teams/ITeamManager.php',
'OCP\\Teams\\ITeamResourceProvider' => __DIR__ . '/../../..' . '/lib/public/Teams/ITeamResourceProvider.php',
Expand Down
26 changes: 25 additions & 1 deletion lib/private/Teams/TeamManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use OCA\Circles\Model\Probes\CircleProbe;
use OCP\IURLGenerator;
use OCP\Server;
use OCP\Teams\ITeamFileResourceProvider;
use OCP\Teams\ITeamFolderProvider;
use OCP\Teams\ITeamManager;
use OCP\Teams\ITeamResourceProvider;
Expand Down Expand Up @@ -130,8 +131,31 @@ public function getTeamsForResource(string $providerId, string $resourceId, stri
return [];
}

return array_map($this->circleToTeam(...), $this->getTeams($this->collectTeamIds($providerId, $resourceId), $userId));
}

/**
* When the addressed provider identifies its resources by file id, ask every
* other file provider too: a team folder is mounted rather than shared, so a
* share lookup alone never finds it.
*
* @return list<string>
*/
private function collectTeamIds(string $providerId, string $resourceId): array {
$provider = $this->getProvider($providerId);
return array_map($this->circleToTeam(...), $this->getTeams($provider->getTeamsForResource($resourceId), $userId));
$teamIds = $provider->getTeamsForResource($resourceId);

if ($provider instanceof ITeamFileResourceProvider) {
foreach ($this->getProviders() as $candidate) {
if ($candidate === $provider || !$candidate instanceof ITeamFileResourceProvider) {
continue;
}

$teamIds = array_merge($teamIds, $candidate->getTeamsForFile((int)$resourceId));
}
}

return array_values(array_unique($teamIds));
}

private function getTeamInternal(string $teamId, string $userId, ?CircleProbe $probe = null): ?Circle {
Expand Down
43 changes: 43 additions & 0 deletions lib/public/Teams/ITeamFileResourceProvider.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php

declare(strict_types=1);

/**
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCP\Teams;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Implementable;

/**
* Declares that a provider addresses its resources by file id.
*
* Lookups for a file are widened to every provider implementing this, so a
* relation one provider cannot see can be contributed by another: a team folder
* is mounted rather than shared, so a share lookup will never find it.
*
* Only implement this when {@see ITeamResourceProvider::getTeamsForResource()}
* takes a file id, otherwise the two lookups disagree about what an id means.
*
* Register implementations through
* {@see \OCP\AppFramework\Bootstrap\IRegistrationContext::registerTeamResourceProvider()}.
*
* @since 35.0.0
*/
#[Consumable(since: '35.0.0')]
#[Implementable(since: '35.0.0')]
interface ITeamFileResourceProvider extends ITeamResourceProvider {
/**
* Return the ids of the teams the given file belongs to.
*
* May include teams the current user cannot see; the caller filters those out.
*
* @param int $fileId Id of the file as stored in the file cache.
* @return list<string> Team ids, empty when the file is unrelated to this provider.
* @since 35.0.0
*/
public function getTeamsForFile(int $fileId): array;
}
60 changes: 60 additions & 0 deletions tests/lib/Teams/TeamManagerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use OC\AppFramework\Bootstrap\Coordinator;
use OC\Teams\TeamManager;
use OCP\IURLGenerator;
use OCP\Teams\ITeamFileResourceProvider;
use OCP\Teams\ITeamFolderProvider;
use OCP\Teams\ITeamResourceProvider;
use Test\TestCase;
Expand Down Expand Up @@ -43,6 +44,65 @@ public function testGetTeamFolderProviderReturnsRegisteredFolderProvider(): void
$this->assertSame($folderProvider, $teamManager->getTeamFolderProvider());
}

public function testCollectTeamIdsOnlyAsksTheAddressedProvider(): void {
$teamManager = $this->createTeamManager(true);
$addressed = $this->createMock(ITeamResourceProvider::class);
$addressed->expects($this->once())
->method('getTeamsForResource')
->with('42')
->willReturn(['team-1']);

$fileProvider = $this->createMock(ITeamFileResourceProvider::class);
$fileProvider->expects($this->never())->method('getTeamsForFile');

$this->setProviders($teamManager, ['deck' => $addressed, 'other' => $fileProvider]);

$this->assertSame(['team-1'], $this->collectTeamIds($teamManager, 'deck', '42'));
}

public function testCollectTeamIdsAsksEveryOtherFileProvider(): void {
$teamManager = $this->createTeamManager(true);
$addressed = $this->createMock(ITeamFileResourceProvider::class);
$addressed->method('getTeamsForResource')->with('42')->willReturn(['team-1']);
$addressed->expects($this->never())->method('getTeamsForFile');

$mountProvider = $this->createMock(ITeamFileResourceProvider::class);
$mountProvider->expects($this->once())
->method('getTeamsForFile')
->with(42)
->willReturn(['team-2']);

$unrelated = $this->createMock(ITeamResourceProvider::class);
$unrelated->expects($this->never())->method('getTeamsForResource');

$this->setProviders($teamManager, [
'files' => $addressed,
'groupfolders' => $mountProvider,
'talk' => $unrelated,
]);

$this->assertSame(['team-1', 'team-2'], $this->collectTeamIds($teamManager, 'files', '42'));
}

public function testCollectTeamIdsReturnsEachTeamOnce(): void {
$teamManager = $this->createTeamManager(true);
$addressed = $this->createMock(ITeamFileResourceProvider::class);
$addressed->method('getTeamsForResource')->willReturn(['team-1']);

$mountProvider = $this->createMock(ITeamFileResourceProvider::class);
$mountProvider->method('getTeamsForFile')->willReturn(['team-1', 'team-2']);

$this->setProviders($teamManager, ['files' => $addressed, 'groupfolders' => $mountProvider]);

$this->assertSame(['team-1', 'team-2'], $this->collectTeamIds($teamManager, 'files', '42'));
}

private function collectTeamIds(TeamManager $teamManager, string $providerId, string $resourceId): array {
$method = new \ReflectionMethod(TeamManager::class, 'collectTeamIds');

return $method->invoke($teamManager, $providerId, $resourceId);
}

private function createTeamManager(bool $hasTeamSupport = false): TeamManager {
return new class($this->createMock(Coordinator::class), $this->createMock(IURLGenerator::class), null, $hasTeamSupport, ) extends TeamManager {
public function __construct(
Expand Down
Loading